chore(rna): theming docs #3060
Merged
chore(rna): theming docs #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dbanksdesign
commented
Nov 22, 2022
| @@ -184,19 +184,16 @@ const SecondaryNav = (props) => { | |||
| ))} | |||
| </ExpanderItem> | |||
|
|
|||
| {/* React Native does not yet support theming */} | |||
| @@ -9,7 +9,3 @@ The Authenticator has an option to hide the sign up page including the `Create A | |||
| <Fragment> | |||
| {({ platform }) => import(`./hidesignup.default.${platform}.mdx`)} | |||
| </Fragment> | |||
|
|
|||
| <Example> | |||
There was a problem hiding this comment.
Removed this since it was rendering the React web authenticator
|
|
||
| You can update the style of the Authenticator by wrapping it with a [ThemeProvider](/react-native/theming). Then create a [theme object](/react-native/theming#theme-structure), with all your font customizations. | ||
|
|
||
| ```jsx file=../../../../../../../examples/react-native/src/features/Authenticator/Theming/Example.tsx |
There was a problem hiding this comment.
I assume this is a good idea so we can test the example even if we aren't rendering it in the docs
ioanabrooks
reviewed
Nov 22, 2022
ioanabrooks
reviewed
Nov 22, 2022
ioanabrooks
reviewed
Nov 22, 2022
examples/react-native/src/features/Authenticator/Theming/DarkMode.tsx
Outdated
Show resolved
Hide resolved
calebpollman
approved these changes
Nov 22, 2022
examples/react-native/src/features/Authenticator/Theming/Example.tsx
Outdated
Show resolved
Hide resolved
examples/react-native/src/features/Authenticator/Theming/DarkMode.tsx
Outdated
Show resolved
Hide resolved
…le.tsx Co-authored-by: Caleb Pollman <cpollman@amazon.com>
…ode.tsx Co-authored-by: Caleb Pollman <cpollman@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.