fix(react): Conditionally render deprecation warning #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 942252d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dbanksdesign
previously approved these changes
Jan 5, 2023
| message: | ||
| "The Link component's to prop will soon be deprecated. " + | ||
| 'Please see the Amplify UI documentation for using the Link component with routing libraries: ' + | ||
| 'https://ui.docs.amplify.aws/react/components/link#routing-libraries', | ||
| }); | ||
| return ( | ||
| <View | ||
| as={as} | ||
| as={as ?? 'a'} |
There was a problem hiding this comment.
Should we use a ternary here to be more explicit?
| it('should not call console.warn if "to" prop is used with "as" prop', async () => { | ||
| const spyWarn = jest.spyOn(console, 'warn'); | ||
| render(<SampleRoutingApp />); | ||
| expect(spyWarn).not.toHaveBeenCalled(); |
added 2 commits
January 5, 2023 16:55
…ify/amplify-ui into conditional-deprecation-warning
reesscot
approved these changes
Jan 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Only show the
Linkcomponent'stoprop deprecation warning if the customer does NOT provide anasprop.Fixes: #2889
Issue #, if available
#2889
Description of how you validated changes
Tested locally with a few examples on the docs site.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.