chore(ui-react): lint primitives (T - Z) #3297
Conversation
🦋 Changeset detectedLatest commit: 423715e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/react/.eslintrc.js
Outdated
| // 'X', | ||
| // 'Y', | ||
| // 'Z' | ||
| 'T', |
There was a problem hiding this comment.
If all primitives are done, can we remove these and go back to src/primitives/**/*?
There was a problem hiding this comment.
There is no going back where we've never been 😄
All jokes aside will update the .eslintrc.js in a follow up
There was a problem hiding this comment.
Went ahead and updated the lint config to remove the need templateJoin
| // at this point the child defined (not null or undefined) | ||
| // it is NOT a TabItem, so log a message | ||
| if (child) { | ||
| console.warn( |
There was a problem hiding this comment.
I know you explained this, but why are we not logging a message anymore?
There was a problem hiding this comment.
It was very easy to bypass the isTabsType predicate, so the warning here was also fragile
| * Additionally, `value` is avaialble on the props of `TabItemPrimitive`, but is not present | ||
| * on `TabItemProps`. To mitigate this issue prefer usage of the props of `TabItemPrimitive` | ||
| `*/ | ||
| type ExtendedTabItemProps = Parameters<typeof TabItemPrimitive>[0] & { |
There was a problem hiding this comment.
TIL about Parameters util type!
Description of changes
Lint primitives
T*-Z*Issue #, if available
NA
Description of how you validated changes
yarn react lint && yarn react testChecklist
yarn testpassessideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.