Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ui-react-liveness and FaceLivenessDetector component #3677

Merged
merged 1,068 commits into from
Apr 10, 2023
Merged

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Apr 7, 2023

Description of changes

  • This change introduces the ui-react-liveness package and the FaceLivenessDetector component
  • Includes documentation changes
  • NOTE: make sure to squash and merge when merging this change
  • Note to @aws-amplify/amplify-ui team members, please pay extra attention to files outside of the react-liveness package to ensure that we are not changing the prod GH actions and tests. Particularly the .github folder

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

thaddmt and others added 30 commits January 9, 2023 10:32
* WIP

* chore: update error state handling to only user onError, added onFailure callback
* chore: move default error components to separate components

* chore: update unit tests

* fix: remove unused variable
* refactor(liveness): add liveness example to next dir

* refactor(liveness): fix liveness example in next dir

* refactor(liveness): remove examples/liveness-next

* refactor(liveness): update README and env example

Co-authored-by: MJ☔ <zhamujun@amazon.com>
Co-authored-by: MJ☔ <zhamujun@amazon.com>
…saging (#692)

* fix: handle errors from liveness stream with default server error messaging

* fix: unit tests
* refactor(liveness): TS Strict for helper liveness

* refactor(liveness): TS Strict for liveness helper

* refactor(liveness): TS Strict for liveness helper

* refactor(liveness): add isClientFreshnessColorSequence helper

* refactor(liveness): remove exclude from getColorsSequencesFromSessionInformation

Co-authored-by: MJ☔ <zhamujun@amazon.com>
* fix: remove unused deps webrtc-adapater, aws-sdk-liveness, uuid

* fix: add back in xstate dep

* add  yarn.lock

* fix: unit tests

* fix: fix unit test
* fix: more copy updates

* fix: unit tests
* add pauseVideo action
* update freezeStream to not wait for animation end
* fix: small ux issues for fnf precheck

* fix: unit test
Co-authored-by: MJ☔ <zhamujun@amazon.com>
…, testing this change in beta this has not been reviewed
* fix: switch back to original timestamps

* remove unused method
…) by 10%, testing this change in beta this has not been reviewed" (#712)

This reverts commit 6d81f9f.
* Update FPS message
* update max to maximum

---------

Co-authored-by: Heather Buchel <buchel@amazon.com>
* chore: added mobile landscape warning

* add safari friendly orientation detection (#716)

* add safari friendly orientation detection

* Add isMobile check back

* Add back 480 height to LivenessCheck

---------

Co-authored-by: Heather Buchel <buchel@amazon.com>

* fix lint

* fix unit tests

---------

Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <buchel@amazon.com>
* test(liveness): add popover icon test

* test(liveness): add liveness detector tests

* test(liveness): add disable start screen tests

* test(liveness): add With Custom Components tests

* test(liveness): modify

---------

Co-authored-by: MJ☔ <zhamujun@amazon.com>
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since link checker is expected to fail, let's set continue-on-error to true on that step, so that CI doesn't get blocked when we try to publish to @next.

ioanabrooks
ioanabrooks previously approved these changes Apr 10, 2023
hbuchel
hbuchel previously approved these changes Apr 10, 2023
wlee221
wlee221 previously approved these changes Apr 10, 2023
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After merge, we need to:

  1. Reenable migrate checker once all the links are available
  2. Add back liveness test to build canaries
  3. Migrate liveness environment to us-east-2.

(in order of high priority to low priority).

@thaddmt thaddmt temporarily deployed to ci April 10, 2023 17:25 — with GitHub Actions Inactive
@thaddmt thaddmt temporarily deployed to ci April 10, 2023 17:25 — with GitHub Actions Inactive
@thaddmt thaddmt temporarily deployed to ci April 10, 2023 17:25 — with GitHub Actions Inactive
@thaddmt thaddmt dismissed stale reviews from wlee221, hbuchel, and ioanabrooks via dafe864 April 10, 2023 17:44
@thaddmt thaddmt temporarily deployed to ci April 10, 2023 18:13 — with GitHub Actions Inactive
@thaddmt thaddmt temporarily deployed to ci April 10, 2023 18:13 — with GitHub Actions Inactive
@thaddmt thaddmt temporarily deployed to ci April 10, 2023 18:13 — with GitHub Actions Inactive
@thaddmt thaddmt temporarily deployed to ci April 10, 2023 18:13 — with GitHub Actions Inactive
@thaddmt thaddmt enabled auto-merge (squash) April 10, 2023 18:24
@thaddmt thaddmt merged commit bc3fd6d into main Apr 10, 2023
@thaddmt thaddmt deleted the liveness-main branch April 10, 2023 18:26
@github-actions github-actions bot mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.