-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ui-react-liveness and FaceLivenessDetector component #3677
Conversation
* WIP * chore: update error state handling to only user onError, added onFailure callback
* chore: move default error components to separate components * chore: update unit tests * fix: remove unused variable
* refactor(liveness): add liveness example to next dir * refactor(liveness): fix liveness example in next dir * refactor(liveness): remove examples/liveness-next * refactor(liveness): update README and env example Co-authored-by: MJ☔ <zhamujun@amazon.com>
Co-authored-by: MJ☔ <zhamujun@amazon.com>
…saging (#692) * fix: handle errors from liveness stream with default server error messaging * fix: unit tests
* refactor(liveness): TS Strict for helper liveness * refactor(liveness): TS Strict for liveness helper * refactor(liveness): TS Strict for liveness helper * refactor(liveness): add isClientFreshnessColorSequence helper * refactor(liveness): remove exclude from getColorsSequencesFromSessionInformation Co-authored-by: MJ☔ <zhamujun@amazon.com>
Co-authored-by: MJ☔ <zhamujun@amazon.com>
…e all video events are done (#697)
* fix: remove unused deps webrtc-adapater, aws-sdk-liveness, uuid * fix: add back in xstate dep * add yarn.lock * fix: unit tests * fix: fix unit test
* fix: more copy updates * fix: unit tests
* add pauseVideo action * update freezeStream to not wait for animation end
* fix: small ux issues for fnf precheck * fix: unit test
Co-authored-by: MJ☔ <zhamujun@amazon.com>
…, testing this change in beta this has not been reviewed
* fix: switch back to original timestamps * remove unused method
* Update FPS message * update max to maximum --------- Co-authored-by: Heather Buchel <buchel@amazon.com>
* chore: added mobile landscape warning * add safari friendly orientation detection (#716) * add safari friendly orientation detection * Add isMobile check back * Add back 480 height to LivenessCheck --------- Co-authored-by: Heather Buchel <buchel@amazon.com> * fix lint * fix unit tests --------- Co-authored-by: Heather Buchel <hbuchel@gmail.com> Co-authored-by: Heather Buchel <buchel@amazon.com>
* test(liveness): add popover icon test * test(liveness): add liveness detector tests * test(liveness): add disable start screen tests * test(liveness): add With Custom Components tests * test(liveness): modify --------- Co-authored-by: MJ☔ <zhamujun@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since link checker is expected to fail, let's set continue-on-error
to true on that step, so that CI doesn't get blocked when we try to publish to @next
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. After merge, we need to:
- Reenable migrate checker once all the links are available
- Add back liveness test to build canaries
- Migrate liveness environment to us-east-2.
(in order of high priority to low priority).
dafe864
Description of changes
ui-react-liveness
package and theFaceLivenessDetector
componentreact-liveness
package to ensure that we are not changing the prod GH actions and tests. Particularly the.github
folderIssue #, if available
Description of how you validated changes
Checklist
yarn test
passessideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.