chore: fix Primitive types

[zchenwei]

Description of changes

This PR aims to fix the component types to provide typescript users with better type hints.

The PR does the following things:

• Update component props to include the underlying HTML attributes and keep the custom props in a base interface. For example, BaseButtonProps includes only the custom props defined by ourselves while ButtonProps includes the custom props plus all button HTML attributes.
• Use the new types to simply typings and fix type errors in other react packages that get caught by the typed View component.
• Deprecate to prop on Link primitive as part of the clean up

For code reviewers, the major changes are in view.ts under the types folder and the rest of them is just boiler plate updates accordingly.

• Replace the util types with those from react types out of the box
• Create an interface that extends the return type of React.forwardRef and overload the JSX constructor to support polymorphic components with as prop by taking generics.

Follow-ups that we want to tackle:

• Update components prop to explicitly define children prop if necessary for future proof since its implicit declaration has been removed in the latest react types. The PR adds children prop to BaseComponentProps to maintain the same behavior as usual and will not address it altogether considering the scope and priority.

Issue #, if available

• Fixes When used as link, Button shows Typescript error on href prop #2761
• Fixes Allow Buttons to be a link with href prop #2400

• Fixes primitives(Flex): Event handlers for Flex as="form" are not typed properly #2891

• Fixes View component does not have types #2614

Description of how you validated changes

Checklist

• Have read the Pull Request Guidelines
• PR description included
• Relevant documentation is changed or added (and PR referenced)
• yarn test passes and tests are updated/added
• No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[changeset-bot]

⚠️ No Changeset found

Latest commit: c97954a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[calebpollman]

🚢