React/border width color style via style props #4161
Merged
+533
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s://github.com/judygab/amplify-ui into react/border-width-color-style-via-style-props
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
…s://github.com/judygab/amplify-ui into react/border-width-color-style-via-style-props
…eys from ui package
🦋 Changeset detectedLatest commit: 9f20cec The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hbuchel
commented
Jun 23, 2023
There was a problem hiding this comment.
This update was missing from the original PR, it affects the props table on View docs page.
calebpollman
approved these changes
Jun 23, 2023
ioanabrooks
approved these changes
Jun 23, 2023
Merged
5 tasks
zchenwei
pushed a commit
that referenced
this pull request
Jun 23, 2023
* add border color, width and style in style props * Create happy-jeans-wonder.md * update borderColor and borderWidth prop types * update react test snapshot * Update packages/react/src/primitives/shared/constants.ts Co-authored-by: Heather Buchel <hbuchel@gmail.com> * updated test snaps * chore: update borderWidth to use BorderWidthKeys, export BorderWidthKeys from ui package * chore: update docs props tables * chore: update changeset to include ui package --------- Co-authored-by: judygab <ivditigabeskiria@gmail.com> Co-authored-by: Heather Buchel <buchel@amazon.com> Co-authored-by: judygab <50160672+judygab@users.noreply.github.com> Co-authored-by: Ioana Brooks <68251134+ioanabrooks@users.noreply.github.com>
Closed
2 tasks
wlee221
pushed a commit
that referenced
this pull request
Jul 14, 2023
* add border color, width and style in style props * Create happy-jeans-wonder.md * update borderColor and borderWidth prop types * update react test snapshot * Update packages/react/src/primitives/shared/constants.ts Co-authored-by: Heather Buchel <hbuchel@gmail.com> * updated test snaps * chore: update borderWidth to use BorderWidthKeys, export BorderWidthKeys from ui package * chore: update docs props tables * chore: update changeset to include ui package --------- Co-authored-by: judygab <ivditigabeskiria@gmail.com> Co-authored-by: Heather Buchel <buchel@amazon.com> Co-authored-by: judygab <50160672+judygab@users.noreply.github.com> Co-authored-by: Ioana Brooks <68251134+ioanabrooks@users.noreply.github.com>
wlee221
pushed a commit
that referenced
this pull request
Jul 14, 2023
* add border color, width and style in style props * Create happy-jeans-wonder.md * update borderColor and borderWidth prop types * update react test snapshot * Update packages/react/src/primitives/shared/constants.ts Co-authored-by: Heather Buchel <hbuchel@gmail.com> * updated test snaps * chore: update borderWidth to use BorderWidthKeys, export BorderWidthKeys from ui package * chore: update docs props tables * chore: update changeset to include ui package --------- Co-authored-by: judygab <ivditigabeskiria@gmail.com> Co-authored-by: Heather Buchel <buchel@amazon.com> Co-authored-by: judygab <50160672+judygab@users.noreply.github.com> Co-authored-by: Ioana Brooks <68251134+ioanabrooks@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening contributor PR from #3965 from our repo. I've merged in all the latest changes from main and smoke tested locally again.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.