Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): update border and background tokens #4368

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

hbuchel
Copy link
Contributor

@hbuchel hbuchel commented Aug 22, 2023

Description of changes

  • Bumps the error, info, warning and success background tokens down from 20 to 10 for better contrast
  • Add info, warning, and success border tokens
  • Updates affected snapshots and tests

Part of our contrast assessment for Message primitive
Screenshot 2023-08-22 at 4 55 02 PM

Before

Screenshot 2023-08-22 at 4 29 29 PM Screenshot 2023-08-22 at 4 28 34 PM Screenshot 2023-08-22 at 4 34 19 PM

After

Screenshot 2023-08-22 at 4 19 19 PM Screenshot 2023-08-22 at 4 27 55 PM Screenshot 2023-08-22 at 4 28 04 PM

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hbuchel hbuchel requested a review from a team as a code owner August 22, 2023 20:36
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: d49978b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hbuchel hbuchel temporarily deployed to ci August 22, 2023 21:00 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 22, 2023 21:00 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 22, 2023 21:00 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 22, 2023 21:00 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 23, 2023 00:11 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 23, 2023 00:11 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 23, 2023 00:11 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci August 23, 2023 00:11 — with GitHub Actions Inactive
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hbuchel hbuchel merged commit 14e402b into main Aug 23, 2023
@hbuchel hbuchel deleted the UpdateBackgroundBorderTokens branch August 23, 2023 17:18
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants