-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new isMultiple and selectSize props #4414
Conversation
🦋 Changeset detectedLatest commit: 897469b The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Let's make sure to fix the stray package.json and yarn.lock changes that snuck in. Some early feedback:
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
I don't think the |
@lavr001 You'll need to update snapshot tests for the ui package: https://github.com/aws-amplify/amplify-ui/actions/runs/6114903239/job/16597619003?pr=4414
|
added new isMultiple and selectSize props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits for changeset:
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Added new isMultiple and selectSize props for the SelectField component
…ws-amplify/amplify-ui into select-field-add-multiple-attr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Thank you for all the updates!
Description of changes
Added new props
isMultiple
andselectSize
to theSelectField
componenthttps://select-field-add-multiple-attr.dvmvffzts1tcu.amplifyapp.com/react/components/selectfield
Issue #1405 , if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addedsideEffects
field updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.