Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new isMultiple and selectSize props #4414

Merged
merged 34 commits into from
Sep 14, 2023
Merged

Conversation

lavr001
Copy link
Contributor

@lavr001 lavr001 commented Sep 5, 2023

Description of changes

Added new props isMultiple and selectSize to the SelectField component

https://select-field-add-multiple-attr.dvmvffzts1tcu.amplifyapp.com/react/components/selectfield

Issue #1405 , if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 897469b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@aws-amplify/ui-react Patch
@aws-amplify/ui Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let's make sure to fix the stray package.json and yarn.lock changes that snuck in. Some early feedback:

docs/src/pages/[platform]/components/selectfield/react.mdx Outdated Show resolved Hide resolved
docs/src/pages/[platform]/components/selectfield/react.mdx Outdated Show resolved Hide resolved
docs/src/pages/[platform]/components/selectfield/react.mdx Outdated Show resolved Hide resolved
docs/src/pages/[platform]/components/selectfield/react.mdx Outdated Show resolved Hide resolved
packages/ui/src/theme/css/component/select.scss Outdated Show resolved Hide resolved
packages/ui/src/theme/css/component/select.scss Outdated Show resolved Hide resolved
lavr001 and others added 4 commits September 5, 2023 13:56
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
Co-authored-by: Heather Buchel <hbuchel@gmail.com>
@reesscot
Copy link
Contributor

reesscot commented Sep 6, 2023

I don't think the yarn.lock file changes should be in here. Can you remove it and merge from main?

package.json Outdated Show resolved Hide resolved
@reesscot
Copy link
Contributor

reesscot commented Sep 7, 2023

@lavr001 You'll need to update snapshot tests for the ui package: https://github.com/aws-amplify/amplify-ui/actions/runs/6114903239/job/16597619003?pr=4414

yarn ui test -u

@lavr001 lavr001 temporarily deployed to ci September 8, 2023 00:23 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 8, 2023 00:23 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 8, 2023 00:23 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 11, 2023 17:05 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 11, 2023 17:05 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 11, 2023 17:05 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 13, 2023 19:37 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 13, 2023 19:37 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 13, 2023 19:37 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 13, 2023 19:37 — with GitHub Actions Inactive
added new isMultiple and selectSize props
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits for changeset:

.changeset/brave-timers-dream.md Outdated Show resolved Hide resolved
.changeset/brave-timers-dream.md Outdated Show resolved Hide resolved
@lavr001 lavr001 temporarily deployed to ci September 13, 2023 22:32 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 13, 2023 22:32 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 13, 2023 22:32 — with GitHub Actions Inactive
@lavr001 lavr001 temporarily deployed to ci September 13, 2023 22:32 — with GitHub Actions Inactive
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thank you for all the updates!

@hbuchel hbuchel temporarily deployed to ci September 14, 2023 18:50 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 14, 2023 18:50 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 14, 2023 18:50 — with GitHub Actions Inactive
@hbuchel hbuchel temporarily deployed to ci September 14, 2023 18:50 — with GitHub Actions Inactive
@lavr001 lavr001 merged commit d570694 into main Sep 14, 2023
@lavr001 lavr001 deleted the select-field-add-multiple-attr branch September 14, 2023 20:34
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants