BREAKING: Removing stylistic data-attributes #4452
Conversation
🦋 Changeset detectedLatest commit: 401b240 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -43,7 +41,6 @@ exports[`ChangePassword renders as expected 1`] = ` | |||
| aria-checked="false" | |||
| aria-label="Show password" | |||
| class="amplify-button amplify-field-group__control amplify-field__show-password" | |||
| data-fullwidth="false" | |||
There was a problem hiding this comment.
This isn't used either? I don't see a corresponding classname above
There was a problem hiding this comment.
Correct, doing a search in the repo for data-fullwidth only comes up with snapshot tests and vue/angular code. No CSS references it.
There was a problem hiding this comment.
LGTM! Left a couple clarifying questions about data attributes that are remaining, and saw that some unit test names reference the data attributes that no longer exist (would be good to audit the related unit test names in general, didn't comment on all of them)
Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>
Description of changes
These were a tech debt from a while ago cleaning it up.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.