Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authenticator): fixing visual inconsistencies #5389

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

dbanksdesign
Copy link
Contributor

@dbanksdesign dbanksdesign commented Jul 11, 2024

Description of changes

  • Removing any style props from buttons on authenticator to fix font weight inconsistencies
  • Moved the in the Authenticator to be in the same location in the DOM in each view
  • Made the link buttons consistent across Authenticator views

Issue #, if available

#5156

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dbanksdesign dbanksdesign requested a review from a team as a code owner July 11, 2024 16:01
Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 8d45379

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@aws-amplify/ui-react Patch
@aws-amplify/ui-react-auth Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dbanksdesign dbanksdesign merged commit a024885 into main Jul 17, 2024
33 checks passed
@dbanksdesign dbanksdesign deleted the fix-5156 branch July 17, 2024 19:02
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
AhmetAhunbayAWS added a commit that referenced this pull request Jul 30, 2024
* chore(react-core): update useDataState - add hasError property, resolveMaybeAsync util (#5400)

* fix(authenticator): fixing visual inconsistencies (#5389)

* fix(authenticator): Check first radio button from unverified user attributes so that default value is selected (#5399)

* Version Packages (#5419)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(docs): update authenticator services docs for reset password (#5459)

* chore(depenabot): upgrade vue-tsc and remove dep on vue-template-compiler (#5470)

* fix(storage): fix looping calls to processFile (#5477)

* fix(storage): fix looping calls to processFile

* Create four-apricots-compete.md

* update unit tests, ensure onProcessFile is called with path or accessFile

* Version Packages (#5479)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* docs: adds link to environments documentation (#5485)

* docs: adds link to environments documentation

* fix: adds additional link and consolidates

---------

Co-authored-by: Caleb Pollman <cpollman@amazon.com>
Co-authored-by: Danny Banks <djb@amazon.com>
Co-authored-by: Tim Nguyen <54393192+timngyn@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: thaddmt <68032955+thaddmt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants