Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Table Primitive, styling, and docs #568

Merged
merged 50 commits into from
Nov 16, 2021
Merged

Basic Table Primitive, styling, and docs #568

merged 50 commits into from
Nov 16, 2021

Conversation

slaymance
Copy link
Contributor

Issue #, if available: Asana

Description of changes: Adds the basis for the Table primitive, including sub components (TableHead, TableBody, etc.), styling, and basic documentation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@slaymance slaymance marked this pull request as draft October 28, 2021 18:38
@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2021

🦋 Changeset detected

Latest commit: 3d98f71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@slaymance slaymance marked this pull request as ready for review November 1, 2021 21:31
@slaymance slaymance self-assigned this Nov 1, 2021
Comment on lines +1 to +5
---
'@aws-amplify/ui-react': patch
---

Adds React Table primitive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@reesscot
Copy link
Contributor

reesscot commented Nov 2, 2021

@slaymance Please confirm changes and update UI snapshots:

yarn ui test -u

@slaymance slaymance temporarily deployed to ci November 12, 2021 00:22 Inactive
@slaymance slaymance temporarily deployed to ci November 12, 2021 00:22 Inactive
@slaymance slaymance temporarily deployed to ci November 12, 2021 00:22 Inactive
Copy link
Contributor

@hvergara hvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! no comments on my end, approved

packages/ui/src/theme/tokens/components/table.js Outdated Show resolved Hide resolved
@slaymance slaymance temporarily deployed to ci November 15, 2021 20:17 Inactive
@slaymance slaymance temporarily deployed to ci November 15, 2021 20:17 Inactive
@slaymance slaymance temporarily deployed to ci November 15, 2021 20:17 Inactive
@slaymance slaymance merged commit 36d256b into main Nov 16, 2021
@slaymance slaymance deleted the table-primitive branch November 16, 2021 00:30
@github-actions github-actions bot mentioned this pull request Nov 16, 2021
thaddmt pushed a commit that referenced this pull request Apr 7, 2023
Sync amplify-ui to amplify-ui-staging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants