Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(canary): add FileUploader to react canaries #5760

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

thaddmt
Copy link
Member

@thaddmt thaddmt commented Sep 6, 2024

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thaddmt thaddmt requested a review from a team as a code owner September 6, 2024 17:31
Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: b86bab8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

esauerbo
esauerbo previously approved these changes Sep 6, 2024
jordanvn
jordanvn previously approved these changes Sep 6, 2024
Copy link
Member

@jordanvn jordanvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on this, I had overlooked this addition

@@ -46,6 +46,12 @@ export default function Home() {
maxFileCount={1}
isResumable
/>
<FileUploader
acceptedFileTypes={['image/*']}
accessLevel="guest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is the v5 version of the props, can we add v6 versions with path in this test as well for both FileUploader and StorageManager?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    <StorageManager
      acceptedFileTypes={['image/*']}
      path="public/"
      maxFileCount={1}
      isResumable
    />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@thaddmt thaddmt merged commit ac6f63b into main Sep 11, 2024
34 checks passed
@thaddmt thaddmt deleted the storage-canaries branch September 11, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants