-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding resolutions for path-to-regexp to fix dependabot issue #5783
Conversation
|
@@ -88,6 +89,7 @@ | |||
"loader-utils": "2.0.4", | |||
"node-forge": "1.3.0", | |||
"nth-check": "^2.0.1", | |||
"path-to-regexp": "0.1.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just include this one for now, and follow up on the next one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Thad and I confirmed that functionality is restored with just this change
…mplify-ui into path-to-regexp-resolutions
Description of changes
path-to-regexp
0.1.10
& under and3.3.0
& up.serve-handler
's use ofpath-to-regexp
is updated to use3.3.0
, as it cannot use a lower version0.1.10
as recommended for uses of0.1.X
Issue #, if available
Description of how you validated changes
Angular example app was built and ran using the updated dependencies
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.