Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding resolutions for path-to-regexp to fix dependabot issue #5783

Merged
merged 10 commits into from
Sep 16, 2024

Conversation

jordanvn
Copy link
Member

@jordanvn jordanvn commented Sep 10, 2024

Description of changes

  • Resolutions have been added for dependency path-to-regexp
    • This is in response to a dependabot alert
    • Safe versions are 0.1.10 & under and 3.3.0 & up.
      • The serve-handler's use of path-to-regexp is updated to use 3.3.0, as it cannot use a lower version
      • All other uses are now pinned to 0.1.10 as recommended for uses of 0.1.X

Issue #, if available

Description of how you validated changes

Angular example app was built and ran using the updated dependencies

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jordanvn jordanvn requested a review from a team as a code owner September 10, 2024 19:05
Copy link

changeset-bot bot commented Sep 10, 2024

⚠️ No Changeset found

Latest commit: 18c11db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -88,6 +89,7 @@
"loader-utils": "2.0.4",
"node-forge": "1.3.0",
"nth-check": "^2.0.1",
"path-to-regexp": "0.1.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just include this one for now, and follow up on the next one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thad and I confirmed that functionality is restored with just this change

thaddmt
thaddmt previously approved these changes Sep 10, 2024
@jordanvn jordanvn merged commit f2fb980 into main Sep 16, 2024
33 checks passed
@jordanvn jordanvn deleted the path-to-regexp-resolutions branch September 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants