Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): fix placeholder matching rn e2e android #5793

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix(e2e): fix placeholder matching rn e2e android #5793

merged 1 commit into from
Sep 11, 2024

Conversation

thaddmt
Copy link
Member

@thaddmt thaddmt commented Sep 11, 2024

Description of changes

  • Noticed when running e2e RN android tests locally this placeholder test would consistently fail
  • Updated to match by testId
  • Updated to check attribute on element
  • Example failure screenshot below to see what throwing looking like
Screenshot 2024-09-11 at 12 08 22 PM

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thaddmt thaddmt requested a review from a team as a code owner September 11, 2024 19:34
Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: 1f32db3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thaddmt thaddmt merged commit 7b4d97f into main Sep 11, 2024
39 checks passed
@thaddmt thaddmt deleted the e2e-rn-fix branch September 11, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants