-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react): add support for react 19 #5826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 52c4865 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
calebpollman
changed the title
chore(react): update react & react-dom types pre-react 19
[WIP} chore(react): add support for react 19
Dec 6, 2024
calebpollman
force-pushed
the
react/bump-react-types
branch
from
December 16, 2024 23:47
1721702
to
3a8fc36
Compare
calebpollman
changed the title
[WIP} chore(react): add support for react 19
[WIP] chore(react): add support for react 19
Dec 16, 2024
calebpollman
force-pushed
the
react/bump-react-types
branch
4 times, most recently
from
December 17, 2024 01:28
b860b9e
to
78ba219
Compare
calebpollman
force-pushed
the
react/bump-react-types
branch
from
December 17, 2024 02:04
78ba219
to
6da6e66
Compare
jordanvn
reviewed
Dec 19, 2024
calebpollman
changed the title
[WIP] chore(react): add support for react 19
chore(react): add support for react 19
Dec 19, 2024
calebpollman
commented
Dec 19, 2024
pranavosu
reviewed
Dec 19, 2024
tiffanynwyeung
approved these changes
Dec 19, 2024
pranavosu
approved these changes
Dec 19, 2024
jordanvn
approved these changes
Dec 19, 2024
Merged
I'm still seeing older versions of dependencies that don't support React 19:
When running I'm running:
|
tiffanynwyeung
pushed a commit
that referenced
this pull request
Jan 3, 2025
* Revert "chore: remove temporary pin to react 18 in react@latest build tests (#6274)" This reverts commit d9ee32d. * Revert "fix(docs): remove typo from liveness detector core docs (#6256)" This reverts commit 9d71dd8. * Revert "chore(react): remove radix-ui upgrades (#6268)" This reverts commit c623990. * Revert "chore(changeset): update react 19 changeset from patch to minor bump (#6269)" This reverts commit 7045aed. * Revert "chore(storage-browser): bump up package size limit (#6267)" This reverts commit a79b8e9. * Revert "chore(react): add support for react 19 (#5826)" This reverts commit 954e9be. * chore: add changeset
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add React 19 support for React web packages. While definitely a large PR, the bulk of the changes are changes due to the removal of the global
JSX
namespace in the React 19 types.react@^19
andreact-dom@^19
peer deps in React web and core packages (React Native does not supportreact@^19
currently), example:update
ForwardRefPrimitive
interface to provide componentProps
andElement
type generics to returnedReact.Element
(ref). This change allows support of React 19 element typing while continuing support of React versions previous to 19.update
JSX.Foo
->React.JSX.Foo
due to globalJSX
namespace removal in React 19, example:undefined
to emptyuseRef
callsites:add
"jest"
and"@testing-library/jest-dom"
to"types"
field of tsconfig.base.json to allow usage of@testing-library/jest-dom
extendedjest
matchersupdate and align (where appropriate) React related dev and direct dependency versions in example apps and packages:
react@18.2
->react@^18.3
@types/react@^18.2.22
->@types/react@^18.3
react-dom@18.2
->react-dom@^18.3
@types/react-dom@^18.2.7
->@types/react-dom@^18.3.0
react-test-renderer@^18.2.0
->react-test-renderer@^18.3.0
@types/react-test-renderer@^18.0.2
->@types/react-test-renderer@^18.3.0
react-hook-form@"^7.43.5
->react-hook-form@^7.53.2
@testing-library/react-native@^12.3.0
->@testing-library/react-native@^12.9.0
bump
StorageBrowser
size thresholds due to radix dep size increasesremove
"react-router-dom"
dev dependency used in a singleLink
primitive unit test and the test itselffix typing of
DropZone
primitive components to no longer accept unsupportedforwardRef
, example (ref):"@types/emscripten"
and"@types/long"
to@aws-amplify/ui-react-liveness
tsconfig.json (ref)Issue #, if available
closes #6084
Description of how you validated changes
yarn lint && yarn build
vite
andnext@15
example apps (https://github.com/calebpollman/react-19-smoke-tests) using React 19 support tagged version of@aws-amplifyui-react@react-19
(npm)Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.