fix(liveness): fix camera select showing up with one camera, fix came… #5845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra changing weirdness with hair check screen
|
jordanvn
reviewed
Sep 26, 2024
| UPDATE_DEVICE_AND_STREAM: { actions: 'updateDeviceAndStream' }, | ||
| UPDATE_DEVICE_AND_STREAM: { | ||
| actions: 'updateDeviceAndStream', | ||
| target: 'start', |
There was a problem hiding this comment.
Info: is this setting it so that when the device and stream are updated, we return to the start state?
jordanvn
reviewed
Sep 26, 2024
| @@ -507,6 +507,31 @@ describe('LivenessCameraModule', () => { | |||
| ).toBeInTheDocument(); | |||
| }); | |||
|
|
|||
| it('should render hair check screen when isStart = true, should not render camera selector if only one camera', () => { | |||
There was a problem hiding this comment.
Nit: do we need to check if the hair check screen is rendered when isStart = true here when that's the purpose of the preceding test?
jordanvn
approved these changes
Sep 26, 2024
calebpollman
approved these changes
Sep 27, 2024
5 tasks
thaddmt
added a commit
that referenced
this pull request
Sep 30, 2024
* chore(liveness): allow selecting all cameras, allow camera selection … (#5833) * chore(liveness): allow selecting all cameras, allow camera selection on mobile * only show on mobile with facemovement challenge only * relax e2e tests on alpha * make more reaadable * fix * update names * refactor, add tests * Update packages/react-liveness/src/components/FaceLivenessDetector/LivenessCheck/LivenessCameraModule.tsx Co-authored-by: Caleb Pollman <cpollman@amazon.com> * refactor --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> * fix(liveness): fix camera select showing up with one camera, fix camera changing weirdness with hair check screen (#5845) --------- Co-authored-by: thaddmt <68032955+thaddmt@users.noreply.github.com> Co-authored-by: Caleb Pollman <cpollman@amazon.com>
5 tasks
esauerbo
added a commit
that referenced
this pull request
Nov 1, 2024
* chore(liveness): allow selecting all cameras, allow camera selection … (#5833) * chore(liveness): allow selecting all cameras, allow camera selection on mobile * fix(liveness): fix camera select showing up with one camera, fix camera changing weirdness with hair check screen (#5845) * fix(liveness): Only apply transform style on user-facing video (#5953) * fix(liveness): Fix oval render when switching cameras (#5954) --------- Co-authored-by: thaddmt <68032955+thaddmt@users.noreply.github.com> Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: Emma Sauerborn <70536670+esauerbo@users.noreply.github.com> Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>
esauerbo
added a commit
that referenced
this pull request
Nov 6, 2024
* chore(liveness): allow selecting all cameras, allow camera selection … (#5833) * chore(liveness): allow selecting all cameras, allow camera selection on mobile * only show on mobile with facemovement challenge only * relax e2e tests on alpha * make more reaadable * fix * update names * refactor, add tests * Update packages/react-liveness/src/components/FaceLivenessDetector/LivenessCheck/LivenessCameraModule.tsx Co-authored-by: Caleb Pollman <cpollman@amazon.com> * refactor --------- Co-authored-by: Caleb Pollman <cpollman@amazon.com> * fix(liveness): fix camera select showing up with one camera, fix camera changing weirdness with hair check screen (#5845) * fix(liveness): Only apply transform style on user-facing video (#5953) Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com> * fix(liveness): Fix oval render when switching cameras (#5954) * chore(liveness): update video constraints for selected camera (#6009) --------- Co-authored-by: thaddmt <68032955+thaddmt@users.noreply.github.com> Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: Emma Sauerborn <70536670+esauerbo@users.noreply.github.com> Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ra changing weirdness with hair check screen
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.