Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sto-bro): add filter locations e2e test #6113

Conversation

calebpollman
Copy link
Member

Description of changes

Add an e2e test for filtering locations

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@calebpollman calebpollman requested a review from a team as a code owner November 16, 2024 22:00
Copy link

changeset-bot bot commented Nov 16, 2024

⚠️ No Changeset found

Latest commit: e6dd768

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Then I see the first button containing "public"
Then I do not see the button containing "private"
When I click the button containing "Clear search"
Then I see the first button containing "private"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs EOF newline?

Copy link
Member

@jordanvn jordanvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we'll maintain the public and private directories for testing. Surprised these steps didn't already exist, but confirmed that I couldn't find equivalent functionality

@calebpollman calebpollman merged commit d16138c into feat-storage-browser/main Nov 17, 2024
31 checks passed
@calebpollman calebpollman deleted the feat-storage-browser/add-list-locations-e2e-tests branch November 17, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants