-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sto-bro): add filter locations e2e test #6113
chore(sto-bro): add filter locations e2e test #6113
Conversation
|
Then I see the first button containing "public" | ||
Then I do not see the button containing "private" | ||
When I click the button containing "Clear search" | ||
Then I see the first button containing "private" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs EOF newline?
packages/e2e/features/ui/components/storage/storage-browser/filter-locations.feature
Outdated
Show resolved
Hide resolved
…lter-locations.feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming we'll maintain the public
and private
directories for testing. Surprised these steps didn't already exist, but confirmed that I couldn't find equivalent functionality
Description of changes
Add an e2e test for filtering locations
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes and tests are updated/addeddocs
,e2e
,examples
, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.