Skip to content

Conversation

@wapa5pow
Copy link
Contributor

@wapa5pow wapa5pow commented Mar 31, 2025

Description of changes

There are translation (i18n) key mismatch for 'Incorrect username or password.'.
Some languages are not correctly set.

Issue #, if available

no Issue #

Description of how you validated changes

There is only 'Incorrect username or password.' key in source code.
Some languages are correctly set but others are not.

image

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wapa5pow wapa5pow requested a review from a team as a code owner March 31, 2025 23:59
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 90a0b29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@aws-amplify/ui Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch
@aws-amplify/ui-react-geo Patch
@aws-amplify/ui-test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wapa5pow wapa5pow force-pushed the fix-translation-key branch from 7137e46 to 4efb159 Compare April 3, 2025 10:31
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing these @wapa5pow! Left some feedback that should be easily resolved

@wapa5pow wapa5pow requested a review from calebpollman May 10, 2025 22:00
@wapa5pow wapa5pow requested a review from calebpollman May 13, 2025 04:43
@soberm soberm changed the title fix translation key mismatch fix: translation key mismatch Sep 23, 2025
@soberm soberm merged commit 414b67a into aws-amplify:main Sep 23, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants