-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changeset for Primitives + Theming Release #747
Conversation
🦋 Changeset detectedLatest commit: 524357e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we'll make a final pass at the result in #596 ? Or what's the best place to editorialize & "collapse" them all into our first major release?
(I recognize that subsequent releases are best for changesets to communicate patches/minors)
@ericclemmons Right, the final pass will be at #596. It's just that it's the best practice to add new I opened this PR because this "major" bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbanksdesign Since this will be top of the changelog, the bulk of it will be editorialized and likely cross-link to docs beyond summarizing what's in this.
.changeset/four-melons-double.md
Outdated
'@aws-amplify/ui': major | ||
--- | ||
|
||
Added new UI primtives and theming API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dbanksdesign Can you add some content here that will headline our changelog?
I basically restated the goals & linked the RFC + docs:
https://github.com/aws-amplify/amplify-ui/pull/745/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
chore(liveness): move screen brightness instruction to the top
Issue #, if available:
Description of changes: Adds changeset for primitives + theming release. Added a placeholder for now.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.