Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changeset for Primitives + Theming Release #747

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Nov 17, 2021

Issue #, if available:

Description of changes: Adds changeset for primitives + theming release. Added a placeholder for now.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

🦋 Changeset detected

Latest commit: 524357e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui-react Major
@aws-amplify/ui Major
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@wlee221 wlee221 temporarily deployed to ci November 17, 2021 17:47 Inactive
@wlee221 wlee221 temporarily deployed to ci November 17, 2021 17:47 Inactive
@wlee221 wlee221 temporarily deployed to ci November 17, 2021 17:47 Inactive
Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we'll make a final pass at the result in #596 ? Or what's the best place to editorialize & "collapse" them all into our first major release?

(I recognize that subsequent releases are best for changesets to communicate patches/minors)

@wlee221 wlee221 requested a review from dbanksdesign November 17, 2021 17:50
@wlee221
Copy link
Contributor Author

wlee221 commented Nov 17, 2021

@ericclemmons Right, the final pass will be at #596. It's just that it's the best practice to add new changeset on its own PRs. #596 are just a consumer of changesets (you get to see what happens, but not modify) and are not meant to be editoralized.

I opened this PR because this "major" bump changeset will be at the top of the changelogs and is important enough to be its own PR.

Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbanksdesign Since this will be top of the changelog, the bulk of it will be editorialized and likely cross-link to docs beyond summarizing what's in this.

'@aws-amplify/ui': major
---

Added new UI primtives and theming API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbanksdesign Can you add some content here that will headline our changelog?

I basically restated the goals & linked the RFC + docs:

https://github.com/aws-amplify/amplify-ui/pull/745/files

Copy link
Contributor

@slaymance slaymance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ericclemmons ericclemmons merged commit 81169c6 into main Nov 18, 2021
@ericclemmons ericclemmons deleted the GA/primitives branch November 18, 2021 20:33
@swaminator swaminator temporarily deployed to ci November 18, 2021 20:35 Inactive
@swaminator swaminator temporarily deployed to ci November 18, 2021 20:35 Inactive
@swaminator swaminator temporarily deployed to ci November 18, 2021 20:35 Inactive
@github-actions github-actions bot mentioned this pull request Nov 18, 2021
@swaminator swaminator temporarily deployed to ci November 18, 2021 20:51 Inactive
thaddmt added a commit that referenced this pull request Apr 7, 2023
chore(liveness): move screen brightness instruction to the top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants