Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish language pack adjusted to recent changes in main #828

Merged
merged 11 commits into from
Nov 29, 2021

Conversation

gornypiotr
Copy link
Contributor

Issue #, if available: None

Description of changes:
Polish translations file

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2021

🦋 Changeset detected

Latest commit: 25348f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ericclemmons ericclemmons added the I18n An issue for a missing Localization / Translation / Internationalization label Nov 22, 2021
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @strugman, thanks for your contribution! Can you do us a favor and add an entry about Polish support in our docs?

The file is located in https://github.com/aws-amplify/amplify-ui/blob/main/docs/src/pages/components/authenticator/index.page.mdx. You would add pl - Polish to Line 376-382, which lists supported languages in alphabetical order.

@gornypiotr
Copy link
Contributor Author

Hello @strugman, thanks for your contribution! Can you do us a favor and add an entry about Polish support in our docs?

The file is located in https://github.com/aws-amplify/amplify-ui/blob/main/docs/src/pages/components/authenticator/index.page.mdx. You would add pl - Polish to Line 376-382, which lists supported languages in alphabetical order.

Hiya
no problem - I've just pushed a change. Please note, languages were not listed there in alphabetical order, so I've reordered them.

Comment on lines 376 to 383
- `de` – German
- `en` – English (default)
- `zh` – Chinese
- `es` – Spanish
- `fr` – French
- `de` – German
- `it` – Italian
- `ja` – Japenese
- `es` – Spanish
- `pl` - Polish
- `zh` – Chinese
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad, I meant alphabetical with the language names to the right (with English at the top). I'll readjust it, sorry for poorly explaining it!

@wlee221 wlee221 added the run-tests Adding this label will trigger tests to run label Nov 29, 2021
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Nov 29, 2021
@wlee221 wlee221 enabled auto-merge (squash) November 29, 2021 17:58
@wlee221 wlee221 temporarily deployed to ci November 29, 2021 18:03 Inactive
@wlee221 wlee221 temporarily deployed to ci November 29, 2021 18:03 Inactive
@wlee221 wlee221 temporarily deployed to ci November 29, 2021 18:03 Inactive
@wlee221 wlee221 temporarily deployed to ci November 29, 2021 18:20 Inactive
Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @strugman!

@wlee221 wlee221 merged commit 5d11578 into aws-amplify:main Nov 29, 2021
@github-actions github-actions bot mentioned this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n An issue for a missing Localization / Translation / Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants