Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add runtime and compiler gates to OIDCAuthInterceptorAsync OIDCAuthProviderAsync and add files to workspace #104

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

ameter
Copy link
Contributor

@ameter ameter commented Jul 26, 2022

Description of changes:
add runtime and compiler gates to OIDCAuthInterceptorAsync OIDCAuthProviderAsync and add files to workspace

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ameter ameter requested a review from a team as a code owner July 26, 2022 20:24
Copy link
Contributor

@lawmicha lawmicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should pod spec lint still be failing?

pod spec lint

 -> AppSyncRealTimeClient (2.1.0)
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | xcodebuild:  note: Build preparation complete
    - NOTE  | [iOS] xcodebuild:  note: Planning
    - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'Starscream' from project 'Pods')
    - ERROR | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Interceptor/OIDCAuthInterceptorAsync.swift:18:80: error: concurrency is only available in iOS 13.0.0 or newer
    - NOTE  | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Interceptor/OIDCAuthInterceptorAsync.swift:18:17: note: add @available attribute to enclosing instance method
    - NOTE  | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Interceptor/OIDCAuthInterceptorAsync.swift:10:14: note: add @available attribute to enclosing class
    - ERROR | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Interceptor/OIDCAuthInterceptorAsync.swift:47:7: error: concurrency is only available in iOS 13.0.0 or newer
    - NOTE  | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Interceptor/OIDCAuthInterceptorAsync.swift:44:17: note: add @available attribute to enclosing instance method
    - ERROR | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Support/OIDCAuthProviderAsync.swift:9:31: error: concurrency is only available in iOS 13.0.0 or newer
    - NOTE  | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Support/OIDCAuthProviderAsync.swift:9:10: note: add @available attribute to enclosing instance method
    - NOTE  | xcodebuild:  AppSyncRealTimeClient/AppSyncRealTimeClient/Support/OIDCAuthProviderAsync.swift:8:17: note: add @available attribute to enclosing protocol

Analyzed 1 podspec.

[!] The spec did not pass validation, due to 4 errors.

@ameter
Copy link
Contributor Author

ameter commented Jul 26, 2022

should pod spec lint still be failing?

No, it shouldn't. Looking.

@lawmicha
Copy link
Contributor

pod lib lint is successful

 pod lib lint

 -> AppSyncRealTimeClient (2.1.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | xcodebuild:  note: Build preparation complete
    - NOTE  | [iOS] xcodebuild:  note: Planning
    - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [iOS] xcodebuild:  Pods.xcodeproj: warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 15.5.99. (in target 'Starscream' from project 'Pods')

AppSyncRealTimeClient passed validation.

@lawmicha lawmicha merged commit 6a3be5a into aws-amplify:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants