Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add async OIDCAuthProvider protocol #119

Merged
merged 12 commits into from
Apr 17, 2023
Merged

feat: Add async OIDCAuthProvider protocol #119

merged 12 commits into from
Apr 17, 2023

Conversation

royjit
Copy link
Contributor

@royjit royjit commented Apr 14, 2023

Issue #, if available:

Description of changes:
Followup PR that depend on #118 . Uses the new async implementation of interceptors

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@royjit royjit marked this pull request as ready for review April 14, 2023 18:29
@royjit royjit requested a review from a team as a code owner April 14, 2023 18:29
@royjit royjit force-pushed the royjit.useasyncauth branch from fe99996 to 1c1218e Compare April 14, 2023 18:33
jcjimenez
jcjimenez previously approved these changes Apr 14, 2023
Copy link

@jcjimenez jcjimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@royjit royjit force-pushed the royjit.asyncconnection branch from fa14604 to f9efb97 Compare April 14, 2023 22:27
@royjit royjit force-pushed the royjit.useasyncauth branch from 1c1218e to bb88f0c Compare April 14, 2023 22:33
@royjit royjit force-pushed the royjit.useasyncauth branch from 4ca7eac to 2d282ec Compare April 17, 2023 15:50
Base automatically changed from royjit.asyncconnection to main April 17, 2023 19:39
@royjit royjit merged commit 814d7a4 into main Apr 17, 2023
@royjit royjit deleted the royjit.useasyncauth branch April 17, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants