Add Interecptors, ConnectionProviderFactory, and integration test target #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
force-pushed
the
feature/interceptors
branch
from
bca0107 to
5da63b4
Compare
This was referenced Mar 1, 2020
lawmicha
commented
Mar 1, 2020
lawmicha
commented
Mar 1, 2020
| @@ -1,5 +1,8 @@ | |||
| # AppSync RealTime Client for iOS | |||
|
|
|||
| ## 1.0.2 | |||
|
|
|||
| Add Interceptors and interceptor protocols | |||
There was a problem hiding this comment.
going to add more details to this
Refactored the initialization methods to allow consumers to use without taking on a dependency on the auth provider classes vended by AppSync client. The reason for this is to prevent a breaking change, we cannot move the auth provider classes over to AppSyncRealTimeClient or AppSyncClient consumers will have to take on AppSyncRealTimeClient as a dependency. - Add ConnectionProviderFactory class for creating connection providers with auth interceptors. This is the entry point for consumers to pass (url, authInterceptor) to get a connection provider back. - Add integration test target with AppSync backend provisioned
lawmicha
force-pushed
the
feature/interceptors
branch
2 times, most recently
from
a05da67 to
c586449
Compare
lawmicha
force-pushed
the
feature/interceptors
branch
from
c586449 to
8f56c85
Compare
royjit
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactored the initialization methods to allow consumers to use without taking on a dependency on the auth provider classes vended by AppSync client.
The reason for this is to prevent a breaking change, we cannot move the auth provider classes over to AppSyncRealTimeClient or AppSyncClient consumers will
have to take on AppSyncRealTimeClient as a dependency.
This is the entry point for consumers to pass (url, authInterceptor) to get a connection provider back.
Amplify PR aws-amplify/amplify-swift#341
AppSyncClient PR awslabs/aws-mobile-appsync-sdk-ios#353
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.