feat: Upgrade Starscream to 4.0.4 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
force-pushed
the
feat/starscream-4
branch
from
d951799 to
ff30401
Compare
lawmicha
force-pushed
the
feat/starscream-4
branch
from
ff30401 to
656e9df
Compare
lawmicha
commented
Feb 8, 2022
| let serialQueue = DispatchQueue(label: "com.amazonaws.StarscreamAdapter.serialQueue") | ||
| let callbackQueue = DispatchQueue( | ||
| label: "com.amazonaws.StarscreamAdapter.callBack", | ||
| target: serialQueue |
There was a problem hiding this comment.
atierian
reviewed
Feb 8, 2022
| "revision": "37760e9a52030bb9011972c5213c3350fa9d41fd", | ||
| "version": "1.0.0" | ||
| "revision": "df8d82047f6654d8e4b655d1b1525c64e1059d21", | ||
| "version": "4.0.4" |
There was a problem hiding this comment.
👏 This change will remove the "ignoring declared target(s)" warning, correct?
There was a problem hiding this comment.
I didn't reproduce the warning (I may have missed it), but looks like according to this issue https://github.com/aws-amplify/aws-appsync-realtime-client-ios/issues/54, it was due to swift-nio-zlib-support. going up to starscream 4.x.x removes it so i believe the warning will be gone as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
At this time, we'll take the latest version at 4.0.4 https://github.com/daltoniam/Starscream/blob/master/CHANGELOG.md
This is slightly different from #51 in
4.0.4instead of4.0~> 4.0.4instead of~> 4.0.upToNextMinor(from: "4.0.4")instead of.upToNextMajor(from: "4.0.0")If we set it to
~> 4.0, this will pick up all minor versions. Although it may not a breaking change to pick up minor versions, mistakes can happen, which will directly impact customer's updating their dependencies. Setting it to up to next minor (not including) will allow us to perform the upgrade before the customers do, validate/test, and release it explicitly as a new patch update from this library.SPM's
.upToNextMinoris a little confusing in the Apple docs. When I use.upToNextMinor(from: "3.0.0"), it is showing the desired behavior in Package.resolved as"version": "3.0.6". 3.0.6 is the last version of 3.0.0 before 3.1.0/3.1.1. (https://github.com/daltoniam/Starscream/releases) This is what we want, to include all patches, up to and not including the next minor, but apple docs says "going up to the next minor version" which is not what we want.Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.