feat: add swift concurrency (async/await) support #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and MessageInterceptableAsync
atierian
reviewed
May 24, 2022
There was a problem hiding this comment.
Mostly LGTM, just a few questions.
Also, it would be great if we could add a short blurb (a few sentences) to this PR around the decisions to
- Make a separate
asyncprotocol - The nuances of the
TaskQueue
so we have some context around these decisions when looking back at it in the future.
| AppSyncLogger.debug("[RealtimeConnectionProvider] Status: \(self.status). Connectivity status: \(connectivity.status)") | ||
| AppSyncLogger.debug( | ||
| "[RealtimeConnectionProvider] Status: \(self.status). Connectivity status: \(connectivity.status)" | ||
| ) | ||
| if self.status == .connected && connectivity.status == .unsatisfied && !self.isStaleConnection { |
There was a problem hiding this comment.
Not PR applicable, but it would be nice to pull these out into descriptive local computed variables or functions at some point.
...rovider/AppsyncRealtimeConnectionAsync/RealtimeConnectionProviderAsync+StaleConnection.swift
Outdated
Show resolved
Hide resolved
...rovider/AppsyncRealtimeConnectionAsync/RealtimeConnectionProviderAsync+StaleConnection.swift
Outdated
Show resolved
Hide resolved
...rovider/AppsyncRealtimeConnectionAsync/RealtimeConnectionProviderAsync+StaleConnection.swift
Outdated
Show resolved
Hide resolved
...ient/ConnectionProvider/AppsyncRealtimeConnectionAsync/RealtimeConnectionProviderAsync.swift
Show resolved
Hide resolved
AppSyncRealTimeClientTests/Connection/AppSyncSubscriptionConnectionErrorHandlerTests.swift
Show resolved
Hide resolved
…tionAsync/RealtimeConnectionProviderAsync+StaleConnection.swift Co-authored-by: Ian Saultz <52051793+atierian@users.noreply.github.com>
…tionAsync/RealtimeConnectionProviderAsync+StaleConnection.swift Co-authored-by: Ian Saultz <52051793+atierian@users.noreply.github.com>
atierian
approved these changes
May 24, 2022
ameter
added a commit
that referenced
this pull request
May 25, 2022
…ors (#85) Co-authored-by: Ian Saultz <52051793+atierian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
feat: add swift concurrency (async/await) support. Adds support for async interceptors.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.