fix: create valid unauthorized request for odic/userpool connections #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawmicha
force-pushed
the
fix/userpool-unauthorized
branch
from
59053f0 to
c7e4713
Compare
drochetti
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR is part of the efforts to propagate the unauthorized error back to the caller. In the previous PR #69 we are sure that it works for invalid API keys. When testing with endpoint with user pool auth mode, it would fail with a bad request.
The reason for the bad request is because retrieving the token failed, so the request was not modified before attempting the connection. AppSync will return a bad request indicating that the logic for creating the request was invalid.
This PR is to ensure even when the user is not signed in, the library will create a valid request, which then gets validated by AppSync as Unauthorized.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.