fix: supports cross platform builds #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh62
previously approved these changes
Jul 21, 2022
lawmicha
approved these changes
Jul 21, 2022
lawmicha
reviewed
Jul 21, 2022
Package.swift
Outdated
| // The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
|
||
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "AppSyncRealTimeClient", | ||
| platforms: [ | ||
| .iOS(.v13), |
There was a problem hiding this comment.
wait i think... iOS AppSync SDK still uses this, will that impact the SDK to take on new versions of this package?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, this dependency has to match the amplify-ios platform requirements to be compatible.
lawmicha
suggested changes
Jul 21, 2022
There was a problem hiding this comment.
need to verify iOS AppSync SDK dependency on this package, and for within this package, we also have pod support (does PodSpec need to be updated?)
https://github.com/aws-amplify/aws-appsync-realtime-client-ios/blob/main/AppSyncRealTimeClient.podspec
https://github.com/awslabs/aws-mobile-appsync-sdk-ios/blob/main/Package.swift
brennanMKE
force-pushed
the
stehlib.macos
branch
from
4706118 to
586745d
Compare
brennanMKE
changed the title
lawmicha
approved these changes
Jul 25, 2022
lawmicha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#97
Description of changes:
Adds platform versions to Package.swift.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.