Add subscription status callback to subscribeToTopic #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
added
iot
mutablealligator
suggested changes
Jul 25, 2019
...t/src/main/java/com/amazonaws/mobileconnectors/iot/AWSIotMqttSubscriptionStatusCallback.java
Show resolved
Hide resolved
aws-android-sdk-iot/src/main/java/com/amazonaws/mobileconnectors/iot/AWSIotMqttManager.java
Outdated
Show resolved
Hide resolved
| // subscribe to MQTT topic | ||
| mqttManager.subscribeToTopic("sdk/test/integration/ws", AWSIotMqttQos.QOS0, new AWSIotMqttNewMessageCallback() { | ||
| mqttManager.subscribeToTopic("sdk/test/integration/ws", AWSIotMqttQos.QOS0, sscb, new AWSIotMqttNewMessageCallback() { |
There was a problem hiding this comment.
can you keep this test and add a new test for subscribeToTopic with callback for subscription status, that way we don't lose the coverage on the original method.
| * @param qos Quality of Service Level of the subscription. | ||
| * @param subscriptionStatusCallback Callback that will be notified when the subscribe has completed. | ||
| * @param callback Callback to be called when new message is received on this | ||
| * topic for this subscription. |
There was a problem hiding this comment.
can you add a comment in the Javadoc which says when the callback is invoked and when the AmazonClientException is thrown?
|
@desokroshan Add the changelog entry. |
mutablealligator
approved these changes
Aug 1, 2019
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1005
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.