Add changelog entry for keyvaluestore fix #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
added
core
palpatim
reviewed
Aug 20, 2019
CHANGELOG.md
Outdated
| ### Bug Fixes | ||
|
|
||
| - **AWS Core Runtime** | ||
| - Fixed a bug where the data persisted by `CognitoCachingCredentialsProvider`, `CognitoUserPool`, `CognitoAuth` and `AWSMobileClient` cannot be retrieved successfully and resulted in an app crash due to the following scenarios: |
There was a problem hiding this comment.
Suggested reword. Please verify that it's accurate, and run it by @nikhil-dabhade:
- AWS Core Runtime
-
Fixed a bug where encrypted authentication data persisted by the SDK could not be recovered due to:
- The encryption key being removed
- The encryption key being replaced
- The encryption key not being recoverable by the OS
These conditions formerly resulted in an app crash. Now, the errors are logged (without logging sensitive data) and the decryption attempt returns
null, as if the data simply isn't present in the persistent store.Classes affected:
CognitoCachingCredentialsProviderCognitoUserPoolCognitoAuthAWSMobileClient
For more detail, see issues:
-
|
Looks good. |
nikhil-dabhade
approved these changes
Aug 20, 2019
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
* Add changelog entry for keyvaluestore fix * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.