[S3] content md5 in PutObjectResult #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphkim
added
s3
mutablealligator
suggested changes
Oct 14, 2019
| @@ -2003,6 +2003,7 @@ public PutObjectResult putObject(PutObjectRequest putObjectRequest) | |||
| result.setETag(returnedMetadata.getETag()); | |||
| result.setMetadata(returnedMetadata); | |||
| result.setRequesterCharged(returnedMetadata.isRequesterCharged()); | |||
| result.setContentMd5(contentMd5); | |||
There was a problem hiding this comment.
can you add unit and/or integration test for contentMd5 to be null, non-null and contentMd5 passed through ObjectMetadata by the developer?
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1236
Description of changes:
Added a line to set content MD5 in
PutObjectResultto match the behavior in aws-sdk-java.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.