[AWSMobileClient] Add non-null check in accessing fields of SignUpResult #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutablealligator
force-pushed
the
vb-awsmobileclient-signupresult-bug
branch
from
8cfc262 to
da4e835
Compare
mutablealligator
added
mobile client
TrekSoft
reviewed
Oct 29, 2019
awsmobilesdk
pushed a commit
to awsmobilesdk/aws-sdk-android
that referenced
this pull request
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1264
Description of changes:
When the user is confirmed, Cognito does not send
CognitoUserCodeDeliveryDetailsand it appears to be null when the
SignUpResultis unmarshalled. Extract theCognitoUserCodeDeliveryDetailsonly when the user is not confirmed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.