adds custom challenge for first method overload of confirmSignIn #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-android-sdk-mobile-client/src/main/java/com/amazonaws/mobile/client/AWSMobileClient.java
Show resolved
Hide resolved
|
The fix here is also similar to what amplify-js does. |
jamesonwilliams
approved these changes
Dec 30, 2020
hannesj
added a commit
to hannesj/amplify-flutter
that referenced
this pull request
Jan 26, 2021
Update aws-auth-cognito version for Android. This fixes aws-amplify#271 and aws-amplify#276. The the custom challenge answer was fixed in aws-amplify/aws-sdk-android#2316. It was released in version v2.21.0 of the AWS Android SDK, which was included in the version 1.6.9 of the Amplify Android SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-amplify/amplify-flutter#271
aws-amplify/amplify-android#805
#1761
Description of changes:
If confirmSignIn is called without a map for custom challenge, we simply assume that the signInChallengeResponse variable as the attribute for the "ANSWER" key in the .setChallengeResponse's map parameter.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.