Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added identity provider as parameter in Auth Builder #495

Merged
merged 3 commits into from
Aug 17, 2018
Merged

Added identity provider as parameter in Auth Builder #495

merged 3 commits into from
Aug 17, 2018

Conversation

faizanmirza
Copy link
Contributor

No description provided.

@minbi
Copy link
Contributor

minbi commented Jul 13, 2018

Thanks for the PR. We will do some testing and merge ASAP. This looks good.

@shizambles
Copy link

Hi,
When can we expect this PR to be merged? We also have a need to be able to specify the identityprovider (as in the iOS API) so that we can do Facebook authentication. Any way I can help expedite this?

Cheers

@minbi minbi mentioned this pull request Aug 1, 2018
Closed
@minbi minbi merged commit 203303f into aws-amplify:master Aug 17, 2018
sunchunqiang pushed a commit that referenced this pull request Mar 5, 2019
@faizanmirza @minbi
Added identity provider as parameter in Auth Builder (#495)
9fbbc65 
* - Added identity provider as parameter

* - Added set identity method in builder class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minbi minbi minbi approved these changes

@mutablealligator mutablealligator Awaiting requested review from mutablealligator

@mreddyg mreddyg Awaiting requested review from mreddyg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faizanmirza @minbi @shizambles