Fix reconnection failure upon network disconnect(Issue#584) #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
desokroshan
commented
Dec 12, 2018
desokroshan
commented
- Use default value for clean session upon connect and subsequent reconnects if any
- Update mqttWebSocketURL to use endpoint with HTTP Port
1. Set default value for clean session mqtt option 2. Update mqttWebSocketURL to use HTTP Port
Remove unused variables
frankmuellr
added
pull request
iot
Use the default value for clean session option without setting it explicitly
scb01
suggested changes
Dec 14, 2018
| @@ -962,7 +955,7 @@ void reconnectToSession() { | |||
|
|
|||
| try { | |||
| final String mqttWebSocketURL = signer | |||
| .getSignedUrl(endpoint, clientCredentialsProvider.getCredentials(), | |||
There was a problem hiding this comment.
Can you add a comment on why this being changed from "endpoint" to "endpointWithHttpPort"?
scb01
approved these changes
Dec 15, 2018
sunchunqiang
pushed a commit
that referenced
this pull request
Mar 5, 2019
* Fix reconnection failure upon network disconnect 1. Set default value for clean session mqtt option 2. Update mqttWebSocketURL to use HTTP Port * Update AwsIotEndpointUtility.java Remove unused variables * Use default value for clean session Use the default value for clean session option without setting it explicitly * Update AWSIotMqttManager.java * set default cleanSession to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.