New UI, Old docs #1338
Merged
New UI, Old docs #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammartinez
reviewed
Apr 2, 2020
| excerpt: Version of the docs | ||
| cta: Read more | ||
| class: aws-icon-ps-60-circular-circuit | ||
| url: "/sdk/ios/start" |
There was a problem hiding this comment.
Seeing that most of these changes look like prettier doing something, do we want to do the same config change we did for JS last night?
There was a problem hiding this comment.
There is no prettier in docs v1 so I don't believe so. Not sure why my VS code formatted everything..
There was a problem hiding this comment.
I think this is valid formatting though
There was a problem hiding this comment.
Agreed it was more of a callout if it was something with Prettier, which it isn't, and also just seeing what it was.
There was a problem hiding this comment.
This was non-blocking btw
renebrandel
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.