Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Getting Started updates #8130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akilisosa
Copy link

@akilisosa akilisosa commented Nov 24, 2024

Description of changes:

Updated the Angular getting started page to align with current Angular standards and best practices.

Related GitHub issue #, if available:

#7834
#7698

Instructions

Go through
If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akilisosa akilisosa requested review from a team and josefaidt as code owners November 24, 2024 23:30
josefaidt
josefaidt previously approved these changes Nov 25, 2024
Copy link
Contributor

@josefaidt josefaidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @akilisosa thanks for taking the time to file this! change looks good

@akilisosa
Copy link
Author

@josefaidt I was so excited I fixed the Set up Amplify Data page too! If you see any issues please let me know. I wasn't sure how much import information to put there.

Hopefully I can keep this momentum going but no promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants