Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add fit zoom on geofence display #149

Merged
merged 4 commits into from
Apr 14, 2022

Conversation

thaddmt
Copy link
Member

@thaddmt thaddmt commented Apr 11, 2022

Description of changes

  • When displaying geofences try to fit them into the current map view
    • When displaying single geofences just try to update the current map bounds to include those coordinates
    • When displaying all geofences update map bounds to include all geofences and then add some padding to the zoom

some
all

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

@thaddmt thaddmt requested a review from a team April 11, 2022 22:51
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #149 (1fdec05) into main (843a30b) will increase coverage by 1.61%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   40.82%   42.44%   +1.61%     
==========================================
  Files          16       16              
  Lines        1205     1225      +20     
  Branches      162      166       +4     
==========================================
+ Hits          492      520      +28     
+ Misses        713      705       -8     
Impacted Files Coverage Δ
src/AmplifyGeofenceControl/index.ts 65.58% <60.00%> (+7.63%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@thaddmt thaddmt requested a review from a team April 12, 2022 16:45
@thaddmt thaddmt requested a review from slaymance April 12, 2022 18:25
Copy link
Contributor

@slaymance slaymance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thaddmt thaddmt merged commit 711ce00 into aws-amplify:main Apr 14, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.4.2-geo.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

thaddmt added a commit to thaddmt/maplibre-gl-js-amplify that referenced this pull request Apr 15, 2022
slaymance pushed a commit that referenced this pull request Apr 18, 2022
* Revert "chore: Add fit zoom on geofence display (#149)"

This reverts commit 711ce00.

* Revert "fix: fix isExistingGeofenceId logic, add resetGeofence logic to its original polygon (#148)"

This reverts commit 4550387.

* Revert "fix: fix saveGeofence error with empty string (#146)"

This reverts commit becf025.

* Revert "fix: fix geo tagged versions for geofence crud components (#142)"

This reverts commit 636f97f.

* Revert "feat: Add geofence crud component (#138)"

This reverts commit cb35ba1.

* fix: remove getSuggestions API

* chore: move maplibre-gl-geocoder to a regular dep

* fix: properly move maplibre-gl-geocoder to dependency

* v1.6.2

* chore: updated the wrong package previously, update dependencies correctly
@github-actions
Copy link

🎉 This PR is included in version 1.5.0-unstable.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants