-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add geofence crud component #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: fix debounce dependency issue * chore: v1.2.3-geo
* chore: add api documentation for geofence control * chore: update geofenceUtil unit tests
* chore: change to use maplibre-gl-draw-circle * update yarn lock
* chore: fix style for infor button and create modal * chore: fix icon class name
* fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update max-width to 30% for delete popdown * chore: update input box text placeholder * chore: update width for left nav
* fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update max-width to 30% for delete popdown * chore: update input box text placeholder * chore: add navigation controls to geofence component
* fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update delete button styling
* fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update delete button styling * chore: update create geofence error state * chore: fix validation id check * fix: fix lgtm useless conditional
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
===========================================
- Coverage 63.38% 38.92% -24.46%
===========================================
Files 11 16 +5
Lines 396 1120 +724
Branches 117 180 +63
===========================================
+ Hits 251 436 +185
- Misses 145 684 +539
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
TreTuna
approved these changes
Apr 1, 2022
🎉 This PR is included in version 1.3.0-unstable.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
thaddmt
added a commit
that referenced
this pull request
Apr 7, 2022
* chore: Add Geofence Controls by reverting v1.2.1 Revert "fix: prep v1.2.1 launch, revert geofence controls launched with 1.2.0 (#87)" This reverts commit 3d63c06. * chore: prep v1.2.2-geo * fix: move debounce to regular dependency (#92) * fix: fix debounce dependency issue * chore: v1.2.3-geo * chore: rename amplify prefixed classnames to geofence prefixed (#93) * chore: update geo branch to v1.2.4-geo (#95) * chore: update amplify versions to use geo tags (#97) * Geo control docs (#99) * chore: add api documentation for geofence control * chore: update geofenceUtil unit tests * chore: move svg icons to being generated programmatically (#100) * chore: fix geofence api.md link (#102) * chore: change to use maplibre-gl-draw-circle (#101) * chore: change to use maplibre-gl-draw-circle * update yarn lock * chore: prep geo release v1.2.9 (#121) * chore: fix style for info button and create modal (#132) * chore: fix style for infor button and create modal * chore: fix icon class name * Geofences various ux fixes (#134) * fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update max-width to 30% for delete popdown * chore: update input box text placeholder * chore: update width for left nav * Add nav controls (#137) * fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update max-width to 30% for delete popdown * chore: update input box text placeholder * chore: add navigation controls to geofence component * Update delete button style (#135) * fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update delete button styling * Update Geofence Create Error State (#136) * fix: update geofence count on create/delete * fix: update delete success info box styling * chore: update delete button styling * chore: update create geofence error state * chore: fix validation id check * fix: fix lgtm useless conditional * chore: fix error messaging syntax, remove bearing from nav control (#139)
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
thaddmt
added a commit
to thaddmt/maplibre-gl-js-amplify
that referenced
this pull request
Apr 15, 2022
This reverts commit cb35ba1.
slaymance
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Revert "chore: Add fit zoom on geofence display (#149)" This reverts commit 711ce00. * Revert "fix: fix isExistingGeofenceId logic, add resetGeofence logic to its original polygon (#148)" This reverts commit 4550387. * Revert "fix: fix saveGeofence error with empty string (#146)" This reverts commit becf025. * Revert "fix: fix geo tagged versions for geofence crud components (#142)" This reverts commit 636f97f. * Revert "feat: Add geofence crud component (#138)" This reverts commit cb35ba1. * fix: remove getSuggestions API * chore: move maplibre-gl-geocoder to a regular dep * fix: properly move maplibre-gl-geocoder to dependency * v1.6.2 * chore: updated the wrong package previously, update dependencies correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes