Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: programmatically create location marker and remove icon svg #42

Merged
merged 2 commits into from
Aug 27, 2021
Merged

chore: programmatically create location marker and remove icon svg #42

merged 2 commits into from
Aug 27, 2021

Conversation

thaddmt
Copy link
Member

@thaddmt thaddmt commented Aug 26, 2021

Description of changes

  • Originally used a static svg with an HTMLImageElement for the maplibre marker
  • Changed to programmatically creating location svg marker and passing that to the maplibre marker

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]

@thaddmt thaddmt requested a review from reesscot August 26, 2021 23:04
@Amplifiyer
Copy link
Contributor

Is this tested with HTML webpages?

@thaddmt
Copy link
Member Author

thaddmt commented Aug 26, 2021

Is this tested with HTML webpages?

yep!

@thaddmt thaddmt merged commit 9b40bf9 into aws-amplify:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amplifiyer Amplifiyer Amplifiyer approved these changes

@reesscot reesscot Awaiting requested review from reesscot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thaddmt @Amplifiyer