Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated drawPoints method to take NamedLocation data #46

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Sep 1, 2021

Description of changes

  • Added NamedLocation type which contains coordinates, title, and address
  • Updated drawPoints method to take NamedLocation array so that developers can set the title and address for each coordinate in the popup function
  • Example:
drawPoints(
          "myPointData",
          [
            {
              coordinates: [-122.483696, 37.833818],
              title: "foobar",
              address: "foobar",
            },
          ],
          map,
          {
            showCluster: false,
            unclusteredOptions: {
              showMarkerPopup: true,
            },
          }
        );

Screen Shot 2021-09-01 at 2 04 35 PM

Issue #, if available

Description of how you validated changes

  • Tested on local app

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

@thaddmt thaddmt requested a review from TreTuna September 1, 2021 21:05
Copy link
Contributor

@TreTuna TreTuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 nit.

src/popupRender.ts Outdated Show resolved Hide resolved
Co-authored-by: Tré Ammatuna <16496746+TreTuna@users.noreply.github.com>
@thaddmt thaddmt merged commit 1a8133a into aws-amplify:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants