-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoFit option to drawPoints #94
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request introduces 1 alert when merging 1e1bc4d into c04cb5e - view on LGTM.com new alerts:
|
Amplifiyer
reviewed
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, are there any tests we can update?
This pull request introduces 1 alert when merging 39628ca into c04cb5e - view on LGTM.com new alerts:
|
Amplifiyer
approved these changes
Jan 9, 2022
thaddmt
added a commit
that referenced
this pull request
Jan 21, 2022
* fix: change publish workflow if statement (#90) (#91) * feat: add autoFit option to drawPoints (#94) * feat: add autoFit option to drawPoints * chore: update drawPoints unit tests * chore: remove unused variable * chore: add amplify-map.css file with various css configurations (#98) * chore: add amplify-map.css file with various css configurations * Update src/public/amplify-map.css Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com> Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com> * prep v1.2.2 release (#96) * fix: update circleci workflow to use main branch (#104) * chore: prep v1.2.3 (#103) Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com>
thaddmt
added a commit
that referenced
this pull request
Mar 17, 2022
* fix: change publish workflow if statement (#90) (#91) * feat: add autoFit option to drawPoints (#94) * feat: add autoFit option to drawPoints * chore: update drawPoints unit tests * chore: remove unused variable * chore: add amplify-map.css file with various css configurations (#98) * chore: add amplify-map.css file with various css configurations * Update src/public/amplify-map.css Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com> Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com> * prep v1.2.2 release (#96) * fix: update circleci workflow to use main branch (#104) * chore: prep v1.2.3 (#103) * feat: Add stubs for auto suggest api (#106) * feat: Add stubs for auto suggest api * chore: update amplify geo version to include suggestions * chore: update unit tests, fix suggestions response when undefined response * feat: add flag for turning autocomplete off (#110) * fix: update autocomplete logic (#111) * chore: update amplify geocoder API docs (#113) * chore: prep v1.2.4 (#112) * chore: update node publish workflow version (#115) * fix: temporarily disable autocomplete by default (#116) * chore: prep v1.3.1 (#117) * fix: remove regular dependency on maplibre-gl-geocoder (#119) * fix: fix search/getSuggestions when passing in both proximity and bbox (#122) * fix: update sourceId to be the sourceName passed into drawPoints (#123) * fix: update sourceId to be the sourceName passed into drawPoints * fix unit tests * feat: allow for customizing markers with drawPoints (#124) * chore: add codecov (#126) * chore: Switch release process to use semantic-release (#127) * chore: Switch release process to use semantic-release * update node versions to use 16 * trying different v16 node * update more node versions * chore: added commitlint and husky * chore: remove unnecessary github env var * fix: add github token to publish workflow (#129) * Change to use NODE_AUTH_TOKEN (#131) * chore(ci): try switching to node_auth_token * chore: remove npm_token * chore: remove ci-test stuff Co-authored-by: Amplifiyer <51211245+Amplifiyer@users.noreply.github.com> Co-authored-by: Tré Ammatuna <16496746+TreTuna@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passes