-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stackset Resource #6
Conversation
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/CreateHandler.java
Outdated
Show resolved
Hide resolved
...ormation-stackset/src/main/java/software/amazon/cloudformation/stackset/CallbackContext.java
Outdated
Show resolved
Hide resolved
...ormation-stackset/src/main/java/software/amazon/cloudformation/stackset/CallbackContext.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use call chaining pattern plz
...n-stackset/src/main/java/software/amazon/cloudformation/stackset/util/OperationOperator.java
Outdated
Show resolved
Hide resolved
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/CreateHandler.java
Outdated
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/BaseHandlerStd.java
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/BaseHandlerStd.java
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/BaseHandlerStd.java
Show resolved
Hide resolved
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/DeleteHandler.java
Show resolved
Hide resolved
...oudformation-stackset/src/main/java/software/amazon/cloudformation/stackset/ListHandler.java
Show resolved
Hide resolved
...oudformation-stackset/src/main/java/software/amazon/cloudformation/stackset/ListHandler.java
Show resolved
Hide resolved
...oudformation-stackset/src/main/java/software/amazon/cloudformation/stackset/ReadHandler.java
Show resolved
Hide resolved
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/UpdateHandler.java
Outdated
Show resolved
Hide resolved
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/UpdateHandler.java
Outdated
Show resolved
Hide resolved
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/UpdateHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
progress chain looks good
...ormation-stackset/src/main/java/software/amazon/cloudformation/stackset/util/Comparator.java
Show resolved
Hide resolved
...ormation-stackset/src/main/java/software/amazon/cloudformation/stackset/util/Comparator.java
Outdated
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/util/Validator.java
Outdated
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/BaseHandlerStd.java
Show resolved
Hide resolved
...tion-stackset/src/main/java/software/amazon/cloudformation/stackset/util/TemplateParser.java
Outdated
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/util/Validator.java
Show resolved
Hide resolved
...dformation-stackset/src/main/java/software/amazon/cloudformation/stackset/DeleteHandler.java
Outdated
Show resolved
Hide resolved
...set/src/main/java/software/amazon/cloudformation/stackset/translator/PropertyTranslator.java
Show resolved
Hide resolved
...formation-stackset/src/main/java/software/amazon/cloudformation/stackset/BaseHandlerStd.java
Outdated
Show resolved
Hide resolved
Reviewed the StackSets logics are fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
final String templateLocation) { | ||
|
||
final GetTemplateSummaryResponse response = proxyClient.injectCredentialsAndInvokeV2( | ||
getTemplateSummaryRequest(templateBody, templateLocation), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce!
"pattern": "^(ou-[a-z0-9]{4,32}-[a-z0-9]{8,32}|r-[a-z0-9]{4,32})$" | ||
}, | ||
"Capability": { | ||
"type": "string", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an array of the capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, capabilities should be an array. This is the Capability
in definitions
which will be referenced in Capabilities
in properties
.
Great work! Is there a timeframe for bringing this to official CloudFormation (e.g. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html)? |
It might also be useful to change the state in the coverage roadmap: Additionally is their work planned for having separate StackInstance resources? I can see value in being able to define the StackSet in one Stack and StackInstances in another (aws-cloudformation/cloudformation-coverage-roadmap#103). |
Description of changes:
Added new resource AWS::CloudFormation::StackSet
Lastest Revision:
AwsCredentialsExtrator
as it is no longer needed.Testing
Unit Tests
Manually tests
CREATE
/DELETE
/UPDATE
CREATE
/DELETE
/UPDATE
TemplateURL
/TemplateBody
Invalid Template
TemplateURL
/TemplateBody
Known limitation
TemplateURL
andOrganizationUnitIds
can be not retrieve in READ/LIST handlers as StackSet API currently does not allow to do so.Simple Working Template
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.