Skip to content

Commit

Permalink
Add python 3.8 support (#1334)
Browse files Browse the repository at this point in the history
* Add python 3.8 support

* Update integration and deploy stages to use py38

Co-authored-by: Kevin DeJong <kddejong@amazon.com>
  • Loading branch information
chenrui333 and kddejong authored Jan 30, 2020
1 parent 4cad6b9 commit 7eeca49
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 7 deletions.
14 changes: 8 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ stages:
jobs:
include:
- stage: Linting
python: 3.7
env: TOXENV=pylint37
python: 3.8
env: TOXENV=pylint38
- python: 2.7
env: TOXENV=pylint27
- stage: Unit Tests
Expand All @@ -23,16 +23,18 @@ jobs:
- python: 3.5
env: TOXENV=py35
- python: 3.6
env: TOXENV=py36,codecov
env: TOXENV=py36
- python: 3.7
env: TOXENV=py37
- python: 3.8
env: TOXENV=py38, codecov
- stage: Integration
python: 3.7
script: docker run --rm -it -v ${PWD}:/cfnlint -w /cfnlint python:3.7.1-alpine3.8
python: 3.8
script: docker run --rm -it -v ${PWD}:/cfnlint -w /cfnlint python:3.8.1-alpine3.11
/bin/sh -c 'pip3 install -e . && cfn-lint test/fixtures/templates/good/generic.yaml && cat test/fixtures/templates/good/generic.yaml | cfn-lint'
- stage: Deploy
script: skip
python: 3.6
python: 3.8
deploy:
provider: pypi
user: kddejong
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,6 @@ def get_version(filename):
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
],
)
11 changes: 10 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py{27,34,35,36,37},pylint{37,36,27}
envlist = py{27,34,35,36,37,38},pylint{27,36,37,38}

[testenv]
commands =
Expand Down Expand Up @@ -28,6 +28,15 @@ commands =
coverage report
codecov

[testenv:pylint38]
basepython = python3.8
deps =
pylint_quotes
pylint
commands =
pip install -e .
pylint --load-plugins pylint_quotes src/cfnlint

[testenv:pylint37]
basepython = python3.7
deps =
Expand Down

0 comments on commit 7eeca49

Please sign in to comment.