Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote rules #1094

Closed
KarthickEmis opened this issue Aug 12, 2019 · 3 comments
Closed

Remote rules #1094

KarthickEmis opened this issue Aug 12, 2019 · 3 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@KarthickEmis
Copy link

I added my rules and it is in my local path, so in pre commit config.yaml file i added my local path to include the rules. Suppose If i have my own rules in my repo (github) , can we replace my local path to github path in the config.yaml file ?

@kddejong
Copy link
Contributor

We don't have that capability builtin today but I really like this idea

@kddejong kddejong added the enhancement New feature or request label Aug 13, 2019
@kddejong kddejong added the help wanted Extra attention is needed label Sep 2, 2019
@mithun
Copy link

mithun commented Jan 12, 2020

IMO, updating cfn-lint to support remote rule locations will add bloat and complexity to this package. Implementing something like this will require appropriate handling of protocols, URIs, credentials, and caching.

Given that #1216 is merged, an acceptable alternative would be to package, distribute, and install custom rules via pip, which supports various git URIs. Then update your .pre-commit-config.yaml to use the rules (python) package name instead of a local path.

@PatMyron PatMyron removed the help wanted Extra attention is needed label Jun 30, 2020
@PatMyron
Copy link
Contributor

IMO, updating cfn-lint to support remote rule locations will add bloat and complexity to this package. Implementing something like this will require appropriate handling of protocols, URIs, credentials, and caching.

Agree with this. Leaning on the side of Unix philosophy where other tools solve fetching remote files better, especially if handling credentials, and I'd recommend retrieving remote files locally first and then referencing their local copies

similar issues: #1192, aws-cloudformation/cloudformation-guard#24

@PatMyron PatMyron changed the title Additional Rules in pre commit Remote rules Aug 26, 2020
@PatMyron PatMyron added the wontfix This will not be worked on label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants