Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--append-rules from S3 bucket #1192

Closed
mrpackethead opened this issue Nov 11, 2019 · 2 comments
Closed

--append-rules from S3 bucket #1192

mrpackethead opened this issue Nov 11, 2019 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@mrpackethead
Copy link

This is a feature request,

It would be really nice if we could specify an S3 bucket for --append-rules. This would make it easy to share custom rules across our organisation / codebuilder

@kddejong kddejong added the enhancement New feature or request label Nov 11, 2019
@mrpackethead
Copy link
Author

mrpackethead commented Nov 13, 2019

This is What I ended up doign with my Buildspec. AS you can see its copying some files across from S3. I have another pipleine that migrates the contents of a Repo to the S3 bucket, when they are committed. The S3 bucket is available for our team to read, so they can use our custom rules.
I imagine something like this;

cfn-lint template.yaml --append-rules-from-s3 s3://s3bucketname --profile my-aws-profile

I will have a look at the source, this might not be so hard to implement myself.

BuildSpec: |
            version: 0.2
            phases:
              install:
                commands: 
                  - pip install cfn-lint
                  - mkdir msrules
                  - cd msrules
                  - aws s3 cp s3://cfn-lint-rules . --recursive
                  - cd ..
              build:
                commands:
                  - cfn-lint template.yaml --append-rules msrules
            artifacts:
              type: zip
              discard-paths: yes
              files: template.yaml

@PatMyron
Copy link
Contributor

Going to lean on the side of Unix philosophy where other tools solve fetching remote files better, especially if handling credentials, and I'd recommend the solution you landed on

similar issues: aws-cloudformation/cloudformation-guard#24, #1094

@PatMyron PatMyron mentioned this issue Aug 25, 2020
@PatMyron PatMyron added the wontfix This will not be worked on label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants