Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.24.0 has broken AWS::SQS::Queue ReceiveMessageWaitTimeSeconds #1122

Closed
garyevari opened this issue Sep 4, 2019 · 2 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@garyevari
Copy link

garyevari commented Sep 4, 2019

27150ae in #1110
has added the following definition...

{
  "op": "add",
  "path": "/ValueTypes/AWS::SQS::Queue.ReceiveMessageWaitTimeSeconds",
  "value": {
    "NumberMax": 20,
    "NumberMin": 1
  }
},

AWS official documentation found at https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sqs-queues.html specifically states:

"Short polling is used as the default or when you specify 0 for this property"

And at https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-short-and-long-polling.html#sqs-long-polling it states:

"Short polling occurs when the WaitTimeSeconds parameter of a ReceiveMessage request is set to 0 in one of two ways:

The ReceiveMessage call sets WaitTimeSeconds to 0.

The ReceiveMessage call doesn’t set WaitTimeSeconds, but the queue attribute ReceiveMessageWaitTimeSeconds is set to 0."

Therefore, 0 is a perfectly valid value for ReceiveMessageWaitTimeSeconds and working CF definitions are now being flagged as invalid

Also, just as per the AWS Console:
image

@kddejong kddejong added the bug Something isn't working label Sep 4, 2019
@kddejong kddejong self-assigned this Sep 4, 2019
@chuckmeyer
Copy link

Thanks. We have a PR in place and will drop this in a point release -- just waiting to see if anything shakes out today.

@chuckmeyer chuckmeyer self-assigned this Sep 4, 2019
@kddejong
Copy link
Contributor

kddejong commented Sep 4, 2019

Release v0.24.1 is out there and should address this.

@kddejong kddejong closed this as completed Sep 4, 2019
@PatMyron PatMyron added the good first issue Good for newcomers label Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants