Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented Maximums and Minimums of Integer Properties #1110

Merged
merged 28 commits into from
Sep 1, 2019
Merged

Documented Maximums and Minimums of Integer Properties #1110

merged 28 commits into from
Sep 1, 2019

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Aug 26, 2019 •
edited
Loading

Using this PR as a reference: #1109

assuming regional src/cfnlint/data/CloudSpecs/ are autogenerated and wondering if 04_property_values is redundant

"type: integer" "maximum" site:https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource
"type: integer" "minimum" site:https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource
"type: integer" "less than" site:https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource
"type: integer" "more than" site:https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource

Some of these could be automatically sourced from botocore as well: terraform-linters/tflint#274

@PatMyron
AWS::Glue::Job.NumberOfWorkers Maximum
554a53c 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-glue-job.html#cfn-glue-job-numberofworkers
@PatMyron
AWS::IAM::Role.MaxSessionDuration Minimum Maximum
25d90cd 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-role.html#cfn-iam-role-maxsessionduration
@PatMyron
AWS::ElasticLoadBalancingV2::TargetGroup.HealthCheckIntervalSeconds M…
97c24cb 
…inimum Maximum

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-targetgroup.html#cfn-elasticloadbalancingv2-targetgroup-healthcheckintervalseconds
@PatMyron
AWS::ElasticLoadBalancingV2::TargetGroup.UnhealthyThresholdCount Maxi…
3857419 
…mum Minimum

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-targetgroup.html#cfn-elasticloadbalancingv2-targetgroup-unhealthythresholdcount
@PatMyron
AWS::Lambda::Function.MemorySize Maximum Minimum
3dc4922 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html#cfn-lambda-function-memorysize
@PatMyron
AWS::Kinesis::Stream Maximum Minimum
aa50df2 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kinesis-stream.html#cfn-kinesis-stream-retentionperiodhours

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kinesis-stream.html#cfn-kinesis-stream-shardcount
@PatMyron
AWS::Cloud9::EnvironmentEC2.AutomaticStopTimeMinutes Maximum
e0ef302 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloud9-environmentec2.html#cfn-cloud9-environmentec2-automaticstoptimeminutes
@PatMyron
AWS::Lambda::Function.Timeout Maximum Minimum
7066a62 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html#cfn-lambda-function-timeout
@PatMyron
AWS::CodeBuild::Project.(Queued)TimeoutInMinutes Maximum Minimum
4ce8eaf 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-queuedtimeoutinminutes

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-timeoutinminutes
@PatMyron
AWS::Lambda::EventSourceMapping.BatchSize Maximum Minimum
5002e32 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html#cfn-lambda-eventsourcemapping-batchsize
@PatMyron
AWS::Inspector::AssessmentTemplate.DurationInSeconds Maximum Minimum
f7607f7 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-inspector-assessmenttemplate.html#cfn-inspector-assessmenttemplate-durationinseconds
@PatMyron
AWS::ElasticLoadBalancingV2::ListenerRule.Priority Maximum Minimum
1ad5f43 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-listenerrule.html#cfn-elasticloadbalancingv2-listenerrule-priority
@PatMyron
AWS::SageMaker::NotebookInstance.VolumeSizeInGB Maximum Minimum
f01bc8b 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sagemaker-notebookinstance.html#cfn-sagemaker-notebookinstance-volumesizeingb
@PatMyron
AWS::ApiGateway::Authorizer.AuthorizerResultTtlInSeconds Maximum
62bf93d 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-authorizer.html#cfn-apigateway-authorizer-authorizerresultttlinseconds
@PatMyron
AWS::KMS::Key.PendingWindowInDays Maximum Minimum
30fc409 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-kms-key.html#cfn-kms-key-pendingwindowindays
@PatMyron
AWS::FSx::FileSystem.StorageCapacity Maximum Minimum
e6c912b 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-fsx-filesystem.html#cfn-fsx-filesystem-storagecapacity
@PatMyron
AWS::ElastiCache::ReplicationGroup Maximum Minimum
19b1329 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticache-replicationgroup.html#cfn-elasticache-replicationgroup-numcacheclusters

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticache-replicationgroup.html#cfn-elasticache-replicationgroup-replicaspernodegroup
@PatMyron
AWS::DocDB::DBCluster.BackupRetentionPeriod Maximum Minimum
447d88e 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-docdb-dbcluster.html#cfn-docdb-dbcluster-backupretentionperiod
@codecov

This comment has been minimized.

Sign in to view
PatMyron and others added 7 commits August 26, 2019 00:09
@PatMyron
AWS::AppStream::Fleet Maximums Minimums
4d403f9 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appstream-fleet.html#cfn-appstream-fleet-disconnecttimeoutinseconds

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appstream-fleet.html#cfn-appstream-fleet-idledisconnecttimeoutinseconds

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appstream-fleet.html#cfn-appstream-fleet-maxuserdurationinseconds
@PatMyron
AWS::SSM::MaintenanceWindow Maximums Minimums
d25449b 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ssm-maintenancewindow.html#cfn-ssm-maintenancewindow-cutoff

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ssm-maintenancewindow.html#cfn-ssm-maintenancewindow-duration
@PatMyron
AWS::SQS::Queue Maximums Minimums
27150ae 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sqs-queues.html
@PatMyron
AWS::RDS::DB Maximums Minimums
334feaa 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbcluster.html#cfn-rds-dbcluster-backuprententionperiod

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-rds-database-instance.html
@PatMyron
AWS::Redshift::Cluster.NumberOfNodes Maximum Minimum
b9b3802 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-redshift-cluster.html#cfn-redshift-cluster-nodetype
@PatMyron
AWS::Glue::MLTransform.MaxCapacity Maximum
cdc7c32 
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-glue-mltransform.html#cfn-glue-mltransform-maxcapacity
@PatMyron
Merge branch 'master' into master
86cf105
@PatMyron PatMyron changed the title WIP: Documented Maximums and Minimums of Integer Properties Documented Maximums and Minimums of Integer Properties Aug 27, 2019
@kddejong kddejong merged commit 6cce922 into aws-cloudformation:master Sep 1, 2019
@PatMyron
Copy link
Contributor Author

PatMyron commented Mar 5, 2020 •
edited
Loading

I'm assuming the regional files are autogenerated and I'm wondering if 04_property_values is redundant

Circling back on this PR, 04_property_values changes are necessary prerequisites as well and the regional src/cfnlint/data/CloudSpecs/ changes are generated by:

cfn-python-lint $ pip3 install -e . --user
cfn-python-lint $ cfn-lint --update-specs

as described in more detail here

This was referenced Oct 6, 2020
Closed
Merged
@PatMyron PatMyron mentioned this pull request Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddejong kddejong kddejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatMyron @kddejong