checking UpdateReplacePolicy/DeletionPolicy on more resource types #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatMyron
commented
Nov 27, 2019
| def match(self, cfn): | ||
| matches = [] | ||
|
|
||
| resources = cfn.get_resources(resource_type=['AWS::DynamoDB::Table']) |
There was a problem hiding this comment.
thinking about expanding the list of resource types as well
There was a problem hiding this comment.
AWS::CloudFormation::Stack
AWS::EC2::Volume
AWS::ElastiCache::CacheCluster
AWS::ElastiCache::ReplicationGroup
AWS::Neptune::DBCluster
AWS::RDS::DBCluster
AWS::RDS::DBInstance
AWS::Redshift::Cluster
AWS::DynamoDB::Table
AWS::DocDB::DBCluster
AWS::FSx::FileSystem
AWS::EMR::Cluster
AWS::QLDB::Ledger
AWS::Backup::BackupVault
AWS::DocDB::DBInstance
AWS::EFS::FileSystem
AWS::Neptune::DBInstance
AWS::SDB::Domain
AWS::S3::Bucket (won't delete anyways)
This comment has been minimized.
This comment has been minimized.
PatMyron
changed the title
PatMyron
changed the title
…re resource types
kddejong
approved these changes
Dec 12, 2019
This was referenced Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1050, #19
UpdateReplacePolicyDeletionPolicyW3011if explicit policy is delete (follow-up PR)Generated docs with:
To ensure backwards compatibility, CloudFormation itself can't require these policies; set
UpdateReplacePolicyandDeletionPolicybecause defaults lose resources unexpectedly, especially because some property updates cause resource replacementExplicitly set policies to prevent unexpected behavior instead of ignoring these rules, especially since they're enforced internally