Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of EOL 3.4 add in 3.8 #1289

Closed

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jan 8, 2020

Issue #, if available:

Description of changes:

  • Remove support for Python 3.4.
  • Add in support for Python 3.8

PyYAML a dependent package has removed support.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
Copy link
Contributor Author

kddejong commented Jan 8, 2020

Current download proportion rates for Python 3.4 are less than 1%. They will have to pin an older version to continue to download.

@PatMyron maybe we pin pyyaml once to a version supported by Python 3.4 Release. Then EOL.
That way users can have a version that will work until they can migrate.

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1289 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
+ Coverage    87.8%   87.81%   +<.01%     
==========================================
  Files         137      137              
  Lines        8104     8122      +18     
  Branches     1990     1991       +1     
==========================================
+ Hits         7116     7132      +16     
- Misses        584      586       +2     
  Partials      404      404
Impacted Files Coverage Δ
src/cfnlint/helpers.py 83.83% <0%> (-1.2%) ⬇️
src/cfnlint/decode/cfn_json.py 72.33% <0%> (-0.22%) ⬇️
src/cfnlint/transform.py 90.9% <0%> (+0.11%) ⬆️
src/cfnlint/rules/__init__.py 88.8% <0%> (+0.13%) ⬆️
src/cfnlint/config.py 85.71% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a400ae...6ece684. Read the comment docs.

@kddejong kddejong closed this Mar 14, 2020
@kddejong kddejong deleted the Lifecycle/EOL3.4 branch August 3, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant