Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up "update-specs" #1410

Closed

Conversation

miparnisari
Copy link
Contributor

Issue #, if available: #1249

Description of changes:
Speed up --update-specs by using concurrent.futures and spreading the work among several threads.

# before
MacBook@ ~/workspace-sync/cfn-python-lint (master)*$ time cfn-lint --update-specs

real	0m36.339s
user	0m11.634s
sys	0m0.636s

# after
MacBook@ ~/workspace-sync/cfn-python-lint (update-specs-fast)*$ time cfn-lint --update-specs

real	0m13.914s
user	0m12.440s
sys	0m1.590s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PatMyron
Copy link
Contributor

PatMyron commented Apr 6, 2020

cfn-lint --update-specs still generating src/cfnlint/data/CloudSpecs/ changes like the ones here:

pip3 install -e . --user
cfn-lint --update-specs
git status

@miparnisari
Copy link
Contributor Author

Cancelling in favor of #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants